A great ski shop would be one that covered all the 'bases' of and between hardgoods and softgoods. I find that Ontario SUCKS for ski shops, it's really too bad, and the ski show, as awesome as it is, could be a lot better. Carrying all maj. brands of skis, boots, bindings, and apparell is great but it really comes down to the little stuff I find. I agree, WAX, WAX, WAX!!! And good edge sharpeners, and other little "trinket" tools like that. And I always have the worst time finding Helly Hansen long undies... you'd think it'd be easy.
Also, extra stuff, like ski-brand hats, movies, bags, wallets are cool. I like to brag about being a skier. And decent prices that perhaps work with airmiles! And knowledgeable staff, that's a must. Maybe even offer up different things like telemark skis, hiking gear, or It couldn't get much better than that. I honestly don't care about the atmosphere, it may get me to come in but not necessarily buy anything if the swag is too expensive, not the right brand, not there etc. I'd walk into a basement with flourencent lights selling ski equip easily if they carried such a diverse and great range of ski swag.
Furthermore, catering to ALL of the ski industry is a thing, atmosphere can really affect your buisness. Some kids just getting into skiing may be too intimidated to stick around long or even come in or parents looking to shop for/with their kids may not go in either... atmosphere is the tricky bit. Kids can hang out in the ski lodge if they're cold haha